07.02.2019 18:11, Sowjanya Komatineni пишет:
>>
>>
>>> @@ -1124,6 +1453,10 @@ static int tegra_i2c_probe(struct platform_device *pdev)
>>> }
>>> }
>>>
>>> + ret = tegra_i2c_init_dma(i2c_dev);
>>> + if (ret < 0)
>>> + goto disable_div_clk;
>>> +
>>> ret = tegra_i2c_init(i2c_dev);
>>> if (ret) {
>>> dev_err(&pdev->dev, "Failed to initialize i2c controller\n");
>>
>>
>> Missing DMA resourcing release on probe failure.
>
> If probe fails due to other reasons, then I2C interface will not be available and boot will not even happen.
> Do we need DMA resourcing release?
>
Absolutely! Every allocated resource must be released.
