06.02.2019 19:07, Dmitry Osipenko пишет: > 06.02.2019 18:55, Sowjanya Komatineni пишет: >> >> >>>> Two ";;" at the end. >>>> >>>> >>>> >>>> Good news: DVC I2C works now and tps6586x probes fine! :) Bad news: >>>> atmel-touch still has same problems as in V12 :( >>>> >>>> DMA-only V13: http://dpaste.com/0XJ1Z8G.txt >>> >>> Strangely, there are many transactions to touch and all of them are good except DMA timeout only when reading T44 and T5 atmel_mxt_ts 0-004c: Failed to read T44 and T5 (-110) >> >> [ 0.923138] tegra-i2c 7000c000.i2c: starting DMA for length: 16 >> [ 0.923148] tegra-i2c 7000c000.i2c: unmasked irq: 0c >> [ 0.923337] tegra-i2c 7000c000.i2c: transfer complete: 10 0 0 >> [ 0.923347] tegra-i2c 7000c000.i2c: starting DMA for length: 12 >> [ 0.923355] tegra-i2c 7000c000.i2c: unmasked irq: 0c >> [ 0.935048] tegra-i2c 7000d000.i2c: starting DMA for length: 16 >> [ 0.935058] tegra-i2c 7000d000.i2c: unmasked irq: 0c >> [ 1.028750] tegra-i2c 7000c000.i2c: DMA transfer timeout >> [ 1.028816] atmel_mxt_ts 0-004c: __mxt_read_reg: i2c transfer failed (-110) >> >> Looking into timestamps and transactions, DMA timeouts after start of DMA for I2C1 to touch during this transaction. >> While it is waiting for I2C1 DMA transfer, lots of DVC transactions happened thru DMA which are successful >> >> What is the I2C1 speed? > > 400KHz > >> Also incase if device is running slow for some reason, probably timeout was not enough as this patch series changes timeout with base 100mS + msg transfer time based on transfer size. >> Can you give quick try with increased timeout incase if device is running slow? >> > > Tried to increase the timeout to 1 second, doesn't help. > > What helped again is the I2C HW resetting after each transfer. Likely that means that HW isn't programmed correctly, please carefully check every bit. > > DMA-only + I2C HW reset: http://dpaste.com/26AQXFM.txt Seems I found what's the problem. Here is the fix, please include it to v14 if it is correct. diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index a9391c3646b6..5ad54da70304 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -912,7 +912,7 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id) static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev, size_t len) { - u32 val, reg; + u32 val = 0, reg; u8 dma_burst = 0; struct dma_slave_config slv_config = {0}; struct dma_chan *chan; @@ -922,7 +922,6 @@ static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev, reg = I2C_MST_FIFO_CONTROL; else reg = I2C_FIFO_CONTROL; - val = i2c_readl(i2c_dev, reg); if (i2c_dev->is_curr_dma_xfer) { if (len & 0xF)
