On Tue, Feb 05, 2019 at 01:44:44PM +0100, Wolfram Sang wrote: > On Fri, Jan 25, 2019 at 02:11:42PM +0100, Thierry Reding wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > If an I2C adapter doesn't match the provided device tree node, also try > > matching the parent's device tree node. This allows finding an adapter > > based on the device node of the parent device that was used to register > > it. > > > > This fixes a regression on Tegra124-based Chromebooks (Nyan) where the > > eDP controller registers an I2C adapter that is used to read to EDID. > > After commit 993a815dcbb2 ("dt-bindings: panel: Add missing .txt > > suffix") this stopped working because the I2C adapter could no longer > > be found. The approach in this patch fixes the regression without > > introducing the issues that the above commit solved. > > > > Fixes: 17ab7806de0c ("drm: don't link DP aux i2c adapter to the hardware device node") > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > Removed the duplicated Tested-by and applied to for-next, thanks! > > I applied to -next because I want this core change more regression > testing in next. If this goes good, I will do a cleanup series to not > use the of_node of the parent twice. And there is a regression! Good that I didn't push out before double-checking. No one noticed that this breaks registering child devices because of_i2c_register_devices() doesn't have a pointer to work with anymore? Removing that patch from the queue.
Attachment:
signature.asc
Description: PGP signature