Re: [PATCH] i2c: cbus-gpio: Switch to use GPIO descriptors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 5, 2019 at 10:23 PM Aaro Koskinen <aaro.koskinen@xxxxxx> wrote:
> On Tue, Feb 05, 2019 at 01:52:04PM +0100, Linus Walleij wrote:

> Unfortunately it doesn't work, so the device shuts down...
>
> > +static struct gpiod_lookup_table nokia770_cbus_gpio_table = {
> > +        .table = {
> > +                GPIO_LOOKUP("mpuio", 9, "clk", 0),
> > +                GPIO_LOOKUP("mpuio", 10, "dat", 0),
> > +                GPIO_LOOKUP("mpuio", 11, "sel", 0),
> > +             { },
> > +     },
> >  };
>
> Should there be dev_id? I tried adding "i2c-cbus-gpio.2" but it still
> didn't work...

Yeah definately. That is one of the bugs, so I added it.

I also notice that it looks up by index so I'll fix that for a v2
you can test.

> Minor note:
> > +     gpiod_set_consumer_name(chost->dat, "CBUS data");
>
> Maybe use "CBUS dat" to be consistent with other pins.

OK just copied what was already in there. I'll fix.

Yours,
Linus Walleij



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux