Re: [PATCH 2/2] i2c: rcar: refactor TCYC handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 23, 2019 at 06:39:26PM +0100, Wolfram Sang wrote:
> On Wed, Jan 23, 2019 at 11:25:06AM +0100, Simon Horman wrote:
> > On Mon, Jan 21, 2019 at 06:08:00PM +0100, Wolfram Sang wrote:
> > > The latest documentation made it clear that we need to initialize the
> > > TCYC value independently of DMA. Simplify the code to do that.
> > 
> > Hi Wolfram,
> > 
> > I see TCYC bit 6 is no longer used after this patch.
> > Does that warrant a mention in the changelog?
> 
> Do you think so? The old code used TCYC06 (wrongly) for non-DMA transfers.
> The new code sets TCYC up "independently from DMA" <- commit message.

FWIIW, the text above is much clearer to me than the original changelog.
But perhaps that is more a reflection on me than anything else.




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux