Hi Wolfram,
On Thu, Jan 17, 2019 at 1:35 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Update copyright years and add Renesas to it. Add/update comments to
> make driver easier to understand.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/i2c/busses/i2c-sh_mobile.c
> +++ b/drivers/i2c/busses/i2c-sh_mobile.c
> @@ -2,8 +2,8 @@
> /*
> * SuperH Mobile I2C Controller
> *
> - * Copyright (C) 2014 Wolfram Sang <wsa@xxxxxxxxxxxxxxxxxxxx>
> - *
> + * Copyright (C) 2014-19 Renesas Electronics Corporation
Why this addition?
> + * Copyright (C) 2014-19 Wolfram Sang <wsa@xxxxxxxxxxxxxxxxxxxx>
> * Copyright (C) 2008 Magnus Damm
> *
> * Portions of the code based on out-of-tree driver i2c-sh7343.c
> @@ -373,6 +373,7 @@ static int sh_mobile_i2c_isr_rx(struct sh_mobile_i2c_data *pd)
> unsigned char data;
> int real_pos;
>
> + /* switch from TX (address) to RX (data) adds two interrupts */
Perhaps this change can be moved into patch 6/7?
> real_pos = pd->pos - 2;
>
> if (pd->pos == -1) {
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
