Re: [PATCH v2] i2c: imx: don't print error if DMA is not configured

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On 27.11.18 12:31, Wolfram Sang wrote:
Hi,

At least on i.MX5x variants is DMA event for I2C muxed with SDHC. So
it is project specific configuration and not an error.

The patch itself looks okay from a glimpse, but IMHO $subject and
$commit message don't really cut it. This is not so much about not
printing something but refactoring the complete error handling, or? E.g.
you handle -EPROBE_DEFER now, which wasn't the case before. Also, some
dev_dbg are turned to dev_err which is probably okay but confuses a
little reading $subject.

Yes you right. Should I update the subject and resend this patch?



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux