Re: [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 27, 2018 at 10:16:25AM +0100, Hans de Goede wrote:
> One problem is that i2c_new_device() currently simply returns NULL on all
> errors. Andy, you could take a look how much work it is to make that return
> an ERR_PTR too, or just check its return value and return ERR_PTR(-ENXIO) if
> it fails for now...

I would use -ENODEV here and -EINVAL in case there is no ACPI companion :)



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux