Re: [PATCH] py-smbus: fix i2c_smbus_* error propagation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Georgii,

On Wed, 21 Nov 2018 18:45:48 +0300, Georgii Staroselskii wrote:
> It seems like after a switch to uapi headers the Python bindings haven't
> been updated. This led to erronenous behavior every time anything but -1
> is returned by i2c_smbus_* functions.

I can't see how this is related to switching to the uapi headers. The
kernel-provided headers are supposed to be the same as the copies we
were using before.

As far as I can see, the cause of the breakage is:

commit 330bba29f3d02432e2dca6f85082763b248887ff
Author: Jean Delvare
Date:   Tue Jul 10 13:16:54 2012 +0000

    libi2c: Properly propagate real error codes on read errors

So I'll take the blame :-( I find it odd that nobody noticed the
problem in more than 6 years...

Anyway, thanks for reporting and providing the fix, I'll commit it now.

-- 
Jean Delvare
SUSE L3 Support



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux