Re: [PATCH v15 0/2] Add support for USB Type-C interface on latest NVIDIA GPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 29, 2018 at 02:42:37PM +0200, Andy Shevchenko wrote:
> On Fri, Oct 26, 2018 at 09:36:57AM -0700, Ajay Gupta wrote:
> > Hi Heikki and Wolfram,
> > 
> > These two changes add support for USB Type-C interface on latest NVIDIA GPU card.
> > The Type-C controller used is Cypress CCGx and is over I2C interface.
> > 
> > I2C host controller has known limitation of sending STOP after every read. Since
> > each read can be of 4 byte maximum length so there is a limit of 4 byte read.
> > This is mentioned in adapter quirks as "max_read_len = 4"
> > 
> > I2C host controller is mainly used for "write-then-read" or "write" messages so added
> > the flag I2C_AQ_COMB_WRITE_THEN_READ in adapter quirks.
> > 
> > PATCH[2/2] on ucsi driver now have added logic to check i2c adapter quirks and
> > issues i2c read transfer based on max_read_len quirk settings. This will make sure
> > the read limitation is not affecting I2C host which do not have such limitation.
> > 
> > I think the patches should through usb tree because the main functionality is
> > usb Type-C.
> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks, Andy. Your review is worth something :)

May I ask you to add your tag to the individual patches (as long as it
is not a patch bomb), so patchwork will pick them up and I see them
immediately?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux