On Thursday, 19 July 2018 11:42:08 EEST Wolfram Sang wrote:
> > > -static int ov772x_mask_set(struct i2c_client *client, u8 command, u8
> > > mask,
> > > - u8 set)
> > > -{
> > > - s32 val = ov772x_read(client, command);
> > > -
> > > - if (val < 0)
> > > - return val;
> > > -
> > > - val &= ~mask;
> > > - val |= set & mask;
> > > -
> > > - return ov772x_write(client, command, val);
> > > -}
> > > -
> >
> > If I were you I would have kept these functions and wrapped the regmap
> > operations there. This is not an issue though if you prefer it this
> > way :)
>
> I have suggested this way. It is not a show stopper issue, but I still
> like this version better.
Wrapping the regmap functions minimizes the diff and makes it easier to
backport the driver.
--
Regards,
Laurent Pinchart
