Re: [PATCH v2] i2c: tegra: Add support for Tegra194

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 19, 2018 at 12:49:42PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> In order to support advanced features, the I2C FIFO interface was
> changed in the version of the Tegra I2C controller found in Tegra194.
> The changes are backwards incompatible, so the driver needs to be
> programmed in a slightly different way on new chips.
> 
> Add support for MST FIFO programming and add an OF match entry for
> Tegra194. At the same time, mark all prior generations of this
> controller as not having the MST FIFO interface.
> 
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

Applied to for-next, thanks!

My compiler mentions this, though:

drivers/i2c/busses/i2c-tegra.c:170: warning: Function parameter or member 'clk_divisor_fast_plus_mode' not described in 'tegra_i2c_hw_feature'
drivers/i2c/busses/i2c-tegra.c:170: warning: Function parameter or member 'has_multi_master_mode' not described in 'tegra_i2c_hw_feature'
drivers/i2c/busses/i2c-tegra.c:170: warning: Function parameter or member 'has_slcg_override_reg' not described in 'tegra_i2c_hw_feature'
drivers/i2c/busses/i2c-tegra.c:170: warning: Function parameter or member 'has_mst_fifo' not described in 'tegra_i2c_hw_feature'
drivers/i2c/busses/i2c-tegra.c:211: warning: Function parameter or member 'rst' not described in 'tegra_i2c_dev'
drivers/i2c/busses/i2c-tegra.c:211: warning: Function parameter or member 'irq_disabled' not described in 'tegra_i2c_dev'
drivers/i2c/busses/i2c-tegra.c:211: warning: Function parameter or member 'clk_divisor_non_hs_mode' not described in 'tegra_i2c_dev'
drivers/i2c/busses/i2c-tegra.c:211: warning: Function parameter or member 'is_multimaster_mode' not described in 'tegra_i2c_dev'
drivers/i2c/busses/i2c-tegra.c:211: warning: Function parameter or member 'xfer_lock' not described in 'tegra_i2c_dev'

Maybe you want to fix this incrementally?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux