RE: [PATCH 4.18 REGRESSION fix 2/2] i2c-cht-wc: Fix bq24190 supplier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01 July 2018 10:49, Hans de Goede wrote:

> Commit f2a8aa053c17 ("typec: tcpm: Represent source supply through
> power_supply") moved the code to register a power_supply representing
> the device supplying power to the type-C connector, from the fusb302
> code to the generic tcpm code.
> 
> This has caused the power-supply registered by the fusb302 driver,
> which determines how much current the bq24190 can draw, to change name
> from "fusb302-typec-source" to "tcpm-source-psy-i2c-fusb302".
> 
> Fixes: f2a8aa053c17 ("typec: tcpm: Represent source supply through...")
> Cc: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-cht-wc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index 44cffad43701..c4d176f5ed79 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -234,7 +234,8 @@ static const struct irq_chip cht_wc_i2c_irq_chip = {
>  	.name			= "cht_wc_ext_chrg_irq_chip",
>  };
> 
> -static const char * const bq24190_suppliers[] = { "fusb302-typec-source" };
> +static const char * const bq24190_suppliers[] = {
> +	"tcpm-source-psy-i2c-fusb302" };

In the TCPM code, the psy name is a combination of a fixed prefix
'tcpm-source-psy-' and the dev_name of the port controller to ensure we can
handle multiple fusb302 devices in one system. Is this hard coded name here
going to work for all uses of this driver?

> 
>  static const struct property_entry bq24190_props[] = {
>  	PROPERTY_ENTRY_STRING_ARRAY("supplied-from", bq24190_suppliers),
> --
> 2.17.1




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux