On Mon, 2018-06-11 at 18:11 +0300, Andy Shevchenko wrote: > On Mon, 2018-06-11 at 17:22 +0300, Jarkko Nikula wrote: > > Motivation here is to improve debug prints and while doing so to > > remove > > some duplication and separate timing parameter validation from > > actual > > register writes as this parameter validation and/or calculation is > > needed to do only during probe. > > > > Currently debug code prints SCL timing parameters whenever HW is > > reinitialized but doesn't print importand SDA hold time nor actual > > bus > > speed the controller is going to operate. > > > > v3: > > - Fail always if i2c_dw_acquire_lock() returns an error. > > - Keep include statement order > > - Remove redundant "ret = 0; " assignment from i2c_dw_set_sda_hold() > > Still there... > Ah, it is another one. Sorry, didn't notice before. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo