Re: [PATCH v4 2/3] i2c: Retain info->of_node in i2c_new_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 25, 2018 at 02:49:02PM +0200, Boris Brezillon wrote:
> Currently, of_i2c_register_devices() is responsible for retaining
> info->of_node, but we're about to expose a function to parse I2C board
> info without registering the I2C device.
> 
> We could possibly let this function retain ->of_node, but this approach
> is prone to reference leak since people will have to remember to call
> of_node_put() if something goes wrong between the OF node parsing and
> the registration step.
> Let's just retain the ->of_node in i2c_new_register() instead.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>

Applied to for-next, thanks!

What I also like is that the of_node_get/put-pair is in the same source
file now. Much easier to comprehend.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux