Hi Shawn, Am Donnerstag, 17. Mai 2018, 06:02:26 CEST schrieb Shawn Lin: > Now %p doesn't print visible pointer address unless the user > really want it. According to Documentation/core-api/printk-formats.rst, > %px should be used instead, otherwise we could see: > > rk3x-i2c ff110000.i2c: Initialized RK3xxx I2C bus at (____ptrval____) > rk3x-i2c ff130000.i2c: Initialized RK3xxx I2C bus at (____ptrval____) > rk3x-i2c ff3c0000.i2c: Initialized RK3xxx I2C bus at (____ptrval____) > rk3x-i2c ff3d0000.i2c: Initialized RK3xxx I2C bus at (____ptrval____) > > But I don't really understand why we need dump it in the first place! > Let's don't print the visible virtual mapping MMIO address. > > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> But technically, we could also just remove that output line altogether or make it a dev_dbg at least. As it isn't really that useful to spam the kernel log with these messages. Heiko
