Re: [PATCH v6 0/3] add support for Socionext SynQuacer I2C controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> - switch to generic recovery using minimal helpers to drive the SDA/SCL lines
>   directly

If you had added this incrementally, reviewing would have been easier (=
faster). The callbacks look okay...

> - don't recover on every error

... but you are now never recovering. You don't call i2c_recover_bus().

> - add patch to sanity check i2c_transfer() arguments in core code (#3)

See small comment there.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux