Re: [PATCH] i2c: qup: Add shutdown method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 29, 2018 at 12:33 AM, Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:

> And as you say above, the i2c-qup driver does reset the core so this
> should be "less of an issue", not merging this patch means that if there
> is any issues left we expose these to more testing.

I understand that leaving an interrupt pending doesn't really have any
side-effect since the driver reset the device in the probe, although I
still think it's proper for a driver to clear this interrupt when it
shuts down.  I don't want to belabor that point.

However, I don't understand what you mean by "any issues left"?  What
issues?  What value could there be to leaving resources hanging when
the driver shuts down?

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux