Re: [PATCH] i2c: qup: Add shutdown method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 19, 2018 at 10:18 AM, Christ, Austin
<austinwc@xxxxxxxxxxxxxx> wrote:
>> What's the problem with not handling this IRQ? Does the hardware end up
>> in some funky state? Are you worried that the kexec kernel will not
>> function because there's a pending I2C interrupt?
>>
> The potential issue is that if an IRQ is left high, the secondary kernel
> driver for I2C may enter a bad state trying to handle an interrupt that does
> not apply to its context. In the QUP driver case, it may be less of an issue
> because the probe does a soft reset of the core.

Bjorn, do you still have any concerns about this patch?  It seems like
the right thing to do, but I want to make sure you're satisified with
it, and whether it will be accepted for 4.17.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux