On Mon, 26 Mar 2018 12:12:54 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > <boris.brezillon@xxxxxxxxxxx> wrote: > > Document the Cadence I3C gpio expander bindings. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/gpio-cdns-i3c.txt > > > +- #interrupt-cells : Should be 2. The first cell is the GPIO number. > > + The second cell bits[3:0] is used to specify trigger type and level flags: > > + 1 = low-to-high edge triggered. > > + 2 = high-to-low edge triggered. > > + 3 = triggered on both edges. > > + 4 = active high level-sensitive. > > + 8 = active low level-sensitive. > > These are identical to the values in <dt-bindings/interrupt-controller/irq.h>. > Perhaps you can refer to those definitions? Well, I'm not sure this is allowed since DT bindings docs are supposed to be OS-agnostic and macros defined in <dt-bindings/interrupt-controller/irq.h> are, AFAIK, only available to Linux. Note that I copied these definitions from another binding ;-). Rob, any opinion? -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
