2017-12-11 9:08 GMT+01:00 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>: > Hello, > > On Sun, Dec 10, 2017 at 08:29:47PM +0100, Bartosz Golaszewski wrote: >> @@ -625,7 +610,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) >> at24->offset_adj = at24_get_offset_adj(chip.flags, chip.byte_len); >> >> at24->client[0].client = client; >> - at24->client[0].regmap = devm_regmap_init_i2c(client, config); >> + at24->client[0].regmap = devm_regmap_init_i2c(client, &config); >> if (IS_ERR(at24->client[0].regmap)) >> return PTR_ERR(at24->client[0].regmap); >> > > One side effect here that the lockdep name changes from (unhelpful) > "config" to (unhelpful and ugly) "&config". Probably doesn't matter much > ... > > Best regards > Uwe > We can always rename the variable to regmap_config or smth, but in case of a lockdep splat we'll see the stack trace anyway. Thanks, Bartosz
