On Sat, 2017-09-16 at 12:33 +0100, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The structure stm32f7_setup is local to the source and does not need > to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'stm32f7_setup' was not declared. Should it be static? [] > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c [] > @@ -265,7 +265,7 @@ static struct stm32f7_i2c_spec i2c_specs[] = { > }, > }; > > -struct stm32f7_i2c_setup stm32f7_setup = { > +static struct stm32f7_i2c_setup stm32f7_setup = { better to use static const > .rise_time = STM32F7_I2C_RISE_TIME_DEFAULT, > .fall_time = STM32F7_I2C_FALL_TIME_DEFAULT, > .dnf = STM32F7_I2C_DNF_DEFAULT,