On Tuesday, September 5, 2017 5:07:44 PM CEST Mika Westerberg wrote:
> On Tue, Sep 05, 2017 at 04:55:44PM +0200, Rafael J. Wysocki wrote:
> > On Tuesday, September 5, 2017 4:58:35 PM CEST Mika Westerberg wrote:
> > > On Tue, Sep 05, 2017 at 04:46:11PM +0200, Rafael J. Wysocki wrote:
> > > > On Tuesday, September 5, 2017 4:45:11 PM CEST Mika Westerberg wrote:
> > > > > On Mon, Sep 04, 2017 at 12:01:54PM +0200, Rafael J. Wysocki wrote:
> > > > > > static const struct dev_pm_ops dw_i2c_dev_pm_ops = {
> > > > > > - .prepare = dw_i2c_plat_prepare,
> > > > > > - .complete = dw_i2c_plat_complete,
> > > > > > - SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume)
> > > > > > - SET_RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend,
> > > > > > - dw_i2c_plat_resume,
> > > > > > - NULL)
> > > > > > + SET_LATE_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume)
> > > > >
> > > > > This seems to cause problem with intel-lpss MFD driver because it uses
> > > > > .suspend() and .resume() instead of .suspend_late() and .resume_early().
> > > >
> > > > OK, so there is one more dependency here.
> > > >
> > > > Can you please point me to this code?
> > >
> > > It is in drivers/mfd/intel-lpss.c. See intel_lpss_resume().
> > >
> >
> > Looking at it, but I don't quite see how this is related to the
> > i2c-designware-platedv suspend/resume ...
>
> intel-lpss is the parent device for i2c-designware-platdrv. It is
> supposed to handle all LPSS specific stuff, like bringing the PCI device
> out of reset before the i2c-designware-platdrv does its own resume
> things.
Yes, I see.
OK, so what about moving its suspend/resume to the late/early stages?
Would the parent of it be confused?
