On Wed, Jul 19, 2017 at 1:06 AM, Rob Herring <robh@xxxxxxxxxx> wrote: >> static inline struct serdev_controller *to_serdev_controller(struct device *d) >> @@ -172,7 +180,7 @@ static inline void serdev_controller_write_wakeup(struct serdev_controller *ctrl >> { >> struct serdev_device *serdev = ctrl->serdev; >> >> - if (!serdev || !serdev->ops->write_wakeup) >> + if (!serdev || !serdev->ops || !serdev->ops->write_wakeup) > > When is ops ever NULL? Should be a separate change AFIACT. I dumped it; IIRC that happened once during development due to a bug elsewhere. CU Uli