Hi Wolfram, Wondering if you manage to review this patch? It is about loading selected speed mode's sda-hold-time via ACPI. I would like to find out if there are any additional comments? Sincerely Tan Chin Yew > -----Original Message----- > From: Jarkko Nikula [mailto:jarkko.nikula@xxxxxxxxxxxxxxx] > Sent: Tuesday, February 14, 2017 3:01 PM > To: Tan, Chin Yew <chin.yew.tan@xxxxxxxxx>; > andriy.shevchenko@xxxxxxxxxxxxxxx; mika.westerberg@xxxxxxxxxxxxxxx > Cc: linux-i2c@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time > via ACPI > > On 14.02.2017 07:54, chin.yew.tan@xxxxxxxxx wrote: > > From: Tan Chin Yew <chin.yew.tan@xxxxxxxxx> > > > > Sda-hold-time is an important parameter for tuning i2c to meet the > > electrical specification especially for high speed. I2C with incorrect > > sda-hold-time may cause lost arbitration error. Now, the driver is > > able to get sda-hold-time for all the speed supported. > > > > Signed-off-by: Tan Chin Yew <chin.yew.tan@xxxxxxxxx> > > --- > > drivers/i2c/busses/i2c-designware-platdrv.c | 28 > > +++++++++++++++++++++------- > > 1 file changed, 21 insertions(+), 7 deletions(-) > > > > Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html