On 08/01/17 10:15, Hans de Goede wrote: > Hi, > > On 07-01-17 23:23, Jonathan Cameron wrote: >> On 04/01/17 17:55, Jacob Pan wrote: >>> On Tue, 3 Jan 2017 23:10:57 +0100 >>> Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >>> >>>>> It could have been a quirk we had to do on our platforms, I just >>>>> cannot recall the details. Are you testing this on x86 platforms? >>>> >>>> Yes, I've successfully tested this on 2 different models cherrytrail >>>> tablets. >>> >>> [Jacob Pan] I am ok with your change. I last tested on baytrail >>> tablets, I don't know if you have one available to verify. That would >>> be ideal. >>> >> Stable material? As I read this it is a fairly major fix, but we aren't >> entirely sure there wasn't a reason on some platforms for this 'interesting' >> corner of code? >> >> So basically are we sure this won't cause regressions? If so I'll take >> it as a fix and mark for stable. > > The main consumer of the axp288_adc code is the axp288_fuel_gauge driver, > which until now was not really functional. It depended on platform data > being attached to its mfd device, and the provider of that platform data > never got merged. > > I've got patches queued up for 4.11 fixing this. So in practice the chance > of this patch causing regressions is close to 0 as so far it had no > consumers, likewise adding a Cc: stable is not really useful. Cool. I'll queue it for 4.11 as well then. Applied to the togreg branch of iio.git which will be pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > Regards, > > Hans > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
