From: Vladimir Zapolskiy <mailto:vz@xxxxxxxxx> Sent: Thursday, November 17, 2016 8:32 AM > To: Pandy Gao <pandy.gao@xxxxxxx>; wsa@xxxxxxxxxxxxx; u.kleine- > koenig@xxxxxxxxxxxxxx; cmo@xxxxxxxxxxx; robh@xxxxxxxxxx > Cc: linux-i2c@xxxxxxxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; Andy Duan > <fugang.duan@xxxxxxx> > Subject: Re: [Patch V4 2/2] i2c: imx: add devicetree binding for lpi2c > > On 11/14/2016 11:23 AM, Gao Pan wrote: > > Add a binding document for lpi2c driver > > > > Signed-off-by: Gao Pan <pandy.gao@xxxxxxx> > > --- > > .../devicetree/bindings/i2c/i2c-imx-lpi2c.txt | 20 > ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt > > b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt > > new file mode 100644 > > index 0000000..edaf04f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.txt > > @@ -0,0 +1,20 @@ > > +* Freescale Low Power Inter IC (LPI2C) for i.MX > > + > > +Required properties: > > +- compatible : > > + - "fsl,imx8dv-lpi2c" for LPI2C compatible with the one integrated > > +on i.MX8DV soc > > + - "fsl,imx7ulp-lpi2c" for LPI2C compatible with the one integrated > > +on i.MX7ULP soc > > +- reg : address and length of the lpi2c master registers > > +- interrupt-parent : core interrupt controller > > +- interrupts : lpi2c interrupt > > +- clocks : lpi2c clock specifier > > I don't know if description of standard properties is really needed, probably > Rob can advise. > > My point is that pretty "interrupts-extended" is never mentioned, and all three > interrupt* properties are well described in interrupts.txt, and in general there is > no point to mention all those interrupts, clocks, clock-names and friends > properties again and again. > > But here better to get a clarification from Rob. Thanks. > > + > > +Examples: > > + > > +lpi2c7: lpi2c7@40A50000 { > > + compatible = "fsl,imx8dv-lpi2c"; > > + reg = <0x40A50000 0x10000>; > > + interrupt-parent = <&intc>; > > + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clks IMX7ULP_CLK_LPI2C7>; }; > > > > Please rearrange the changes, devicetree binding change should be 1/2, the > driver change should be 2/2. Thanks, will change it in next version. Best Regards Gao Pan ��.n��������+%������w��{.n�����{��-��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
