Re: [PATCH v4 07/14] ARM: dts: koelsch: use demuxer for I2C4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 16, 2016 at 03:14:11PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Nov 16, 2016 at 2:47 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Wed, Nov 16, 2016 at 11:35:22AM +0100, Geert Uytterhoeven wrote:
> >> On Tue, Nov 15, 2016 at 6:44 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> >> >> i2c4 shares pins with vin0. Hence enabling the former breaks the latter:
> >> >>
> >> >>     sh-pfc e6060000.pfc: pin GP_4_13 already requested by
> >> >> e6520000.i2c; cannot claim for e6ef0000.video
> >> >>     sh-pfc e6060000.pfc: pin-141 (e6ef0000.video) status -22
> >> >>     sh-pfc e6060000.pfc: could not request pin 141 (GP_4_13) from
> >> >> group vin0_data24  on device sh-pfc
> >> >>     rcar-vin e6ef0000.video: Error applying setting, reverse things back
> >> >>     rcar-vin: probe of e6ef0000.video failed with error -22
> >> >>
> >> >> There may be similar issues on other boards. Haven't checked yet.
> >> >
> >> > Thanks, I will drop this patch for now.
> >> >
> >> > I checked the boot logs of other boards with similar patches and didn't see
> >> > anything there.
> >>
> >> Do you have CONFIG_VIDEO_ADV7604=y?
> >
> > No, mainly because its not in shmobile_defconfig.
> >
> > I tried again with that option enabled and still didn't see
> > anything of interest in kernel log.
> >
> >> I expect the issue to be present on gose, too. So far I didn't see it
> >> there, yet.
> >> But the vin DTS of gose is different from koelsch, causing vin0 not to be
> >> initialized?
> >
> > It seems so.
> 
> I managed to reproduce the issue on gose, by adding r8a7793 support to
> my koelsch .config.
> Apparently I was missing CONFIG_I2C_DEMUX_PINCTRL=y.

Ok, thanks. Curious that I didn't see it.

It looks like we should drop:

ARM: dts: gose: use demuxer for I2C4
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux