On Mon, Oct 31, 2016 at 01:59:47PM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/i2c/busses/Kconfig:config I2C_PXA_PCI > drivers/i2c/busses/Kconfig: def_bool I2C_PXA && X86_32 && PCI && OF > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_pci_driver() uses the same init level priority as > builtin_pci_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Cc: linux-i2c@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Looks OK to me, still I'd like an ack from Sebastian for this patch.
Attachment:
signature.asc
Description: PGP signature
