From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Fri, 23 Sep 2016 21:30:20 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/i2c/i2c-dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 7d3e3ca..8f7eddd 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -147,7 +147,7 @@ static ssize_t i2cdev_read(struct file *file, char __user *buf, size_t count, count = 8192; tmp = kmalloc(count, GFP_KERNEL); - if (tmp == NULL) + if (!tmp) return -ENOMEM; pr_debug("i2c-dev: i2c-%d reading %zu bytes.\n", @@ -263,7 +263,7 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client, data_ptrs = kmalloc_array(rdwr_arg.nmsgs, sizeof(*data_ptrs), GFP_KERNEL); - if (data_ptrs == NULL) { + if (!data_ptrs) { kfree(rdwr_pa); return -ENOMEM; } @@ -374,7 +374,7 @@ static noinline int i2cdev_ioctl_smbus(struct i2c_client *client, client->flags, data_arg.read_write, data_arg.command, data_arg.size, NULL); - if (data_arg.data == NULL) { + if (!data_arg.data) { dev_dbg(&client->adapter->dev, "data is NULL pointer in ioctl I2C_SMBUS.\n"); return -EINVAL; -- 2.10.0 -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html