Re: [PATCH] i2c-tools: fix feature test macros for glibc >= 2.20

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >  /* For strdup and snprintf */
> > -#define _BSD_SOURCE 1
> > +#define _BSD_SOURCE 1 /* for glibc < 2.19 */
> > +#define _DEFAULT_SOURCE 1 /* for glibc >= 2.20 */
> 
> Actually >= 2.19 if I read the web page you mentioned (which has the
> same "bug") correctly.

On the web page it is not a bug, because it says "If ... you must
support glibc < 2.19 and glibc >= 2.20 then define all three
unconditionally". This is correct since 2.19 works with both options.

However, I should probably use >= 2.19 and <= 2.19 here.

> Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
> 
> Again the 3.1 branch would need the same fix.

Yes.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux