On Wed, Aug 3, 2016 at 5:03 AM, Daniel Wagner <wagi@xxxxxxxxx> wrote: > From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx> > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the completion is: > > bcm_kona_send_i2c_cmd() > reinit_completion() > ... > bcm_kona_i2c_send_cmd_to_ctrl() > ... > wait_for_completion_timeout() > > Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx> Reviewed-by: Tim Kryger <tim.kryger@xxxxxxxxx> > --- > drivers/i2c/busses/i2c-bcm-kona.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/drivers/i2c/busses/i2c-bcm-kona.c > index ac9f476..f987432 100644 > --- a/drivers/i2c/busses/i2c-bcm-kona.c > +++ b/drivers/i2c/busses/i2c-bcm-kona.c > @@ -229,7 +229,7 @@ static irqreturn_t bcm_kona_i2c_isr(int irq, void *devid) > dev->base + TXFCR_OFFSET); > > writel(status & ~ISR_RESERVED_MASK, dev->base + ISR_OFFSET); > - complete_all(&dev->done); > + complete(&dev->done); > > return IRQ_HANDLED; > } > -- > 2.7.4 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
