On Fri, Jun 24, 2016 at 04:12:38PM +0200, Jean Delvare wrote: > Hi Mika, > > On Mon, 13 Jun 2016 12:54:04 +0300, Mika Westerberg wrote: > > On Mon, Jun 13, 2016 at 11:48:30AM +0200, Pali Rohár wrote: > > > I mean to call acpi_remove_address_space_handler() in > > > i801_acpi_io_handler() after acpi_reserved is properly set. > > > > > > As once acpi_reserved is set address space handler is not needed > > > anymore. > > > > It is still needed as we handle all AML OpRegion access in this driver > > from that point forward. Unless I'm missing something. > > I think Pali is correct. The only purpose of handling the region is to > detect that it is being accessed so we can set priv->acpi_reserved. > Once it is set, i801_acpi_io_handler becomes transparent: it forwards > the requests without doing anything with them. The very same would > happen if we would unregister the handler at that point, but without the > extra overhead. > > So while the current code does work fine, unregistering the handler > when we set priv->acpi_reserved would be more optimal. > > Unless both Pali and myself are missing something, that is. I'm not sure unregistering the handler actually resets back to the default handler. Besides, this patch has been already merged for a while so it requires a followup patch on top. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
