On Wed, Jun 08, 2016 at 06:29:13PM +0200, Benjamin Tissoires wrote: > > - err = acpi_check_resource_conflict(&dev->resource[SMBBAR]); > > - if (err) { > > + err = i801_acpi_probe(priv); > > + if (err) > > return -ENODEV; > > - } > > I'd say that once this has been set, we need to call > acpi_remove_address_space_handler() in case of failure later (in the 2 > returns after). Indeed - I wonder how many mistakes one patch can contain :-( Let me fix this and submit yet another version. > The rest looks OK to me. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html