From: Wolfram Sang <wsa@xxxxxxxxxxxxx> Sent: Sunday, April 17, 2016 5:29 AM
> To: Pan Gao <pandy.gao@xxxxxxx>
> Cc: u.kleine-koenig@xxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; Frank Li
> <frank.li@xxxxxxx>; Fugang Duan <fugang.duan@xxxxxxx>
> Subject: Re: [Patch v1] i2c: imx7ulp: add i.MX7ULP i2c controller bus driver
>
> On Tue, Mar 15, 2016 at 05:51:22PM +0800, Gao Pan wrote:
> > Add i.MX7ULP i2c bus driver which can continue operating in stop modes
> > provided an appropriate clock is available.
> >
> > It is also designed for low CPU overhead with DMA offloading of FIFO
> > register accesses.
> >
> > Signed-off-by: Gao Pan <pandy.gao@xxxxxxx>
>
> Since you need to resend anyhow (DT support?), just a few high-level things.
>
Yes, I will send DT patch in the V2.
> There is a lot of dev_dbg in here. Some of them are helpful when developing
> the driver, but not anymore once the driver is upstream.
Ok, will change it in V2. Thanks.
> Please check for that.
>
> > +static int __init i2c_adap_imx_init(void) {
> > + return platform_driver_register(&i2c_imx7ulp_driver);
> > +}
> > +subsys_initcall(i2c_adap_imx_init);
>
> I usually don't accept subsys_initcall() for new drivers anymore. It usually
> works around problems. Make sure your I2C clients do defer probing properly.
Will change it in V2. Thanks.
Thanks.
Pandy.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
