Hello Axel, On Thu, Apr 14, 2016 at 04:29:42PM +0800, Axel Lin wrote: > 2016-04-14 16:24 GMT+08:00 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>: > > On Thu, Apr 14, 2016 at 03:42:54PM +0800, Axel Lin wrote: > >> Make sure we don't OOPS in case clock-frequency is set to 0 in a DT. The > >> variable set here is later used as a divisor. > > > > This is correct in principle. I thought it's ok to misbehave if the DT > > is broken? In this case the current code is just fine. > > Current code hit division by zero if clock-frequency is 0. > clkdiv = DIV_ROUND_UP(rate, 8 * ddata->frequency) - 1; > Is it ok? IMHO yes. If you give the kernel a broken dt it's ok that the kernel is broken then. So if you want, take my: Registered-but-considered-unimportant-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
