On Sun, Apr 03, 2016 at 08:44:43PM +0200, Wolfram Sang wrote: > This series addresses two things which have come up in the past: > > * document that I2C_M_RD is bit 0. It is not good coding style but some > drivers (and userspace) silently assume so anyhow. To avoid regressions, > let's make that explicit. > > * use one function to generate an 8 bit address (7 bit address + RW bit) > from a struct msg. People did this in various ways, sometimes overly > brave and sometimes overly anxious with the operator precedence. That > was partly not nice to read and partly triggering code checkers. > > The new function was tested using a Renesas Lager board with the i2c-sh_mobile > driver. Buildbot was happy with the series, too. A branch can be found here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/8bit_macro > > I'd really appreciate more tests on real HW. Also happy for other comments, > reviews... Applied to for-next, thanks!
Attachment:
signature.asc
Description: PGP signature