Hello, On Wed, Dec 09, 2015 at 11:08:22AM +0800, Gao Pan wrote: > During driver probe, i2c_imx_init_recovery_info() must come before > i2c_add_numbered_adapter(), because the get/set_scl() functions > are assigned in i2c_register_adapter() under the conditon that bus > recover_info are initialized. Otherwise, get/set_scl() function > pointers never get assigned. > > In such case, when i2c_generic_gpio_recovery() is used for bus recovery, > there will be kernel crash because bri->set_scl is NULL. > > The solution to this bug is moving i2c_imx_init_recovery_info() before > i2c_register_adapter(). > > Signed-off-by: Gao Pan <b54642@xxxxxxxxxxxxx> > Signed-off-by: Fugang Duan <B38611@xxxxxxxxxxxxx> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> I wonder why your S-o-b line isn't below Fugang Duan's. These lines are supposed to show the order of people that touched the patch. So usually the Author is the first person to sign off and the person who sends the patch is the last. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
