On Tue, Dec 08, 2015 at 10:37:46AM +0100, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > Inspired from the i2c-rk3x driver (thanks guys!) but refactored and > extended. See built-in docs for further information. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Looks good. I think we can take advantage of this in the designware driver as well. Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> I wonder if it makes sense to add "i2c-sda-hold-time-ns" (taken from the designware driver DT binding) to the timings structure? It is tHD;DAT parameter in the I2C bus specification. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html