Hi Wolfram,
Sorry for it.
I have sent out an i2c runtime patch which was acked by Uwe Kleine. I thought it would be accepted, so I sent out this one based on that one.
Best Regards
Gao Pan
> -----Original Message-----
> From: Wolfram Sang [mailto:wsa@xxxxxxxxxxxxx]
> Sent: Sunday, December 06, 2015 3:08 AM
> To: Gao Pan-B54642
> Cc: u.kleine-koenig@xxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; Li Frank-B20596;
> Duan Fugang-B38611; kernel@xxxxxxxxxxxxxx
> Subject: Re: [Patch V1] i2c: imx: init bus recovery info before adding i2c
> adapter
>
> On Fri, Dec 04, 2015 at 05:33:14PM +0800, Gao Pan wrote:
> > During driver probe, i2c_imx_init_recovery_info() must come before
> > i2c_add_numbered_adapter(), because the get/set_scl() functions are
> > assigned in i2c_register_adapter() under the conditon that bus
> > recover_info are initialized. Otherwise, get/set_scl() function
> > pointers never get assigned.
> >
> > In such case, when i2c_generic_gpio_recovery() is used for bus
> > recovery, there will be kernel crash because bri->set_scl is NULL.
> >
> > The solution to this bug is moving i2c_imx_init_recovery_info() before
> > i2c_register_adapter().
> >
> > Signed-off-by: Gao Pan <b54642@xxxxxxxxxxxxx>
> > Signed-off-by: Fugang Duan <B38611@xxxxxxxxxxxxx>
>
> Makes sense, but I can't apply this one. What is it based on?
--- Begin Message ---
Hello,
On Mon, Nov 30, 2015 at 03:42:15AM +0000, Gao Pandy wrote:
> Ping...
The things I pointed out were fixed. I didn't test it, but the patch
looks reasonable. I'd say it's ready to cook in next until the merge
window opens next time.
If you want to interpret this as an Ack, feel free to do this.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--- End Message ---
