Re: [PATCH] i2c: rcar: make sure clocks are on when doing hw init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram

> >      pm_runtime_get_sync()
> >      myfunc_A()
> >      pm_runtime_put()
> >      ...
> >      pm_runtime_get_sync()
> >      myfunc_B()
> >      pm_runtime_put()
> > 
> > It should be this ?
> > 
> >      pm_runtime_get_sync()
> >      myfunc_A()
> >      myfunc_B()
> >      pm_runtime_put()
> 
> This is for power-off case, right? Wouldn't it be clearer then to add a
> resume function to pm_ops of the I2C driver which reinit the registers?
> Doing it before every transfer might be simpler but is also a bit
> implicit or subtle, I'd think.
> 
> And for completeness: The above is only for the power-off case. In
> module-standby (MSTP bits), register values are always retained.
> Correct?

I'm not sure detail of pm_runtime, but it depends on
power-domain support ?
On SH-Mobile case, it automatically power-off:ed if all driver
user was gone. This feature is not yet supported on R-Car case I think.
So, both case are not problem at this point, but 1st case will be
problem if power-domain was suppored.
(If my memory was correct...)
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux