2015-10-23 6:06 GMT+09:00 Wolfram Sang <wsa@xxxxxxxxxxxxx>: > On Thu, Jul 30, 2015 at 05:12:21PM +0900, Masahiro Yamada wrote: >> Add support for on-chip I2C controller used on newer UniPhier SoCs >> such as PH1-Pro4, PH1-Pro5, etc. This adapter is equipped with >> 8-depth TX/RX FIFOs. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > > Same comments as for the other driver. Fixed in v2. > And quite some debug messages left. Could you check if you still want > them or if they were mostly useful during development of the driver? Yes, I want to keep them. I do not think they are too much. I will probably come back to these drivers when I find some time in order to implement further features such as the slave mode. :) dev_dbg() might be useful for the new development as well as for checking something when hardware went wrong for some reason. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
