Re: [PATCH v2 6/6] i2c: designware: Move common probe code into i2c_dw_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On 10/20/2015 07:32 PM, Wolfram Sang wrote:
There was a merge conflict with a bugfix from i2c/for-current. I think
it is okay, but you may want to double check my i2c/for-next.

Looks like pm_runtime_disable() got dropped from your 36d48fb5766a ("i2c: designware-platdrv: enable RuntimePM before registering to the core") while handling the merge conflict. I'll send a fix.

What about this irq-clearing-in-probe thingie on top of this series? :)

I'll have a look at it. What's not entirely clear to me would it be no-op or not. HW is actually disabled after i2c_dw_init() which is called before requesting the interrupt but is not clear to me from the spec does HW clear interrupts while it goes idle.

So as a result I'd expect either a explicit interrupt clearing patch (to be more robust against potential unmasking changes) or a comment in __i2c_dw_enable() :-)

--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux