On 10/10/2015 10:53 AM, Wolfram Sang wrote:
On Mon, Aug 31, 2015 at 05:31:28PM +0300, Jarkko Nikula wrote:
There is no need to clear interrupts in i2c_dw_pci_probe() since only place
where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts
are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always
clear interrupts before enabling them").
Still, their status might be unclear when we init because firmware might
have used it before. It should be easy to reintroduce this in patch 6,
or?
Yes and then it would be also uniform across different enumeration
methods if we ever need to add it. Now this clearing was done only for
PCI devices. Although I don't think there is any need to add clearing to
probe path as clearing happens beginning of transmit before enabling the
interrupts.
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
