Re: [PATCH] i2c-dev: Fix typo in ioctl name reference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 08, 2015 at 11:05:49AM +0200, Jean Delvare wrote:
> The ioctl is named I2C_RDWR for "I2C read/write". But references to it
> were misspelled "rdrw". Fix them.
> 
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>

Wow! Amazing how long this went unnoticed/unfixed.

> -#define  I2C_RDRW_IOCTL_MAX_MSGS	42
> +#define  I2C_RDWR_IOCTL_MAX_MSGS	42
> +/* Originally defined with a typo, keep if for now for compatibility */

I would drop the 'for now' and keep it forever. A define doesn't hurt
and if it increases backwards compatibility, why not? I will also do
s/if/it/. No need to resend.

> +#define  I2C_RDRW_IOCTL_MAX_MSGS	I2C_RDWR_IOCTL_MAX_MSGS

Thanks!

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux