On Mon, Sep 7, 2015 at 10:00 AM, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > [Me] >> If the use case is around the i2c traffic, it is a mode related to I2C, >> and if this mode is called "GPIO mode" in the data sheet >> is irrelevant, because it is obviously not used for the generic >> input/output but the specific I2C. The terminology should be >> made familiar to whoever needs to go in and read the code later. > > The background info that was obviously missing from the part of the > thread I sent to you is that pinctrl_pm_select_sleep_state is used to > prepare bitbanging on the i2c bus to do bus recovery. (The controller > doesn't implement this, so we have to resort to manually drive the > pins.) I don't understand. What does "manually" mean in this context? Code examples for "manual" and "automatic"? Generally the word "manual" is so ambigous that we should refrain from using it, to me that means something like hammering on a keyboard to alter things through sysfs or debugfs but I hardly believe this is what you mean. > Is this good enough? I'd like to see implemented a separate pinctrl set > for bitbanging instead of relying on the sleep state being the right > thing to enable gpio functionality. This sounds right but I need to see the two different code sets to understand. Now my head is all fuzzy... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
