Wolfram, Jean: On 31 July 2015 at 08:12, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > On Mon, Jul 27, 2015 at 12:47:13PM +0100, Sifan Naeem wrote: >> Following patches are required to fix the existing driver to >> support i2c on pistachio. >> >> Tested on Pistachio bub using an Adafruit I2C Non-Volatile FRAM Breakout >> (256Kbit / 32KByte) eeprom. >> >> Used i2c buildroot tools to test the eeprom and the other i2c blocks. >> Also used dd commands to copy data to and then to dump data from the >> eeprom. i2ctransfer was used to test repeated starts and verified >> using a scope. > > That sounds like good testing \o/ If you are happy with i2ctransfer, > then please consider adding Tested-by tags to the i2ctransfer patches, > so Jean gets a more cosy feeling to include them to i2ctools. > >> Definitely! i2ctransfer was a HUGE help while developing this driver, specially when preparing involved transfers to test repeated starts. Any chance it gets merged in its current state? I think it'll be useful, even if the usage cli API is still a moving target. We could print some warning "i2ctransfer is experimental" or something like that. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html