Re: i2c imx: suspicious use of runtime PM calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Just by chance I stumbled across this driver and the recently added
> > runtime PM code.
> > Two things in i2c_imx_probe look suspicious to me:
> > 
> > - You activate the I2C clock and then initialize runtime PM with
> > 
> >     pm_runtime_enable(&pdev->dev);
> >     pm_runtime_set_autosuspend_delay(&pdev->dev, I2C_PM_TIMEOUT);
> >     pm_runtime_use_autosuspend(&pdev->dev);
> > 
> >   Seems like a call to pm_runtime_set_active is missing to tell runtime
> > PM that the device is in status "active" now.
>  
> Thanks, you are right. I will fix it in next patch.

Thanks Heiner for the report. I dropped this patch and will wait for a
new version.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux