On Thu, Aug 06, 2015 at 03:34:05AM +0300, Laurent Pinchart wrote:
> Hi Wolfram,
>
> Thank you for the patch.
>
> On Wednesday 05 August 2015 15:18:25 Wolfram Sang wrote:
> > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> >
> > Enable the I2C core for this SoC. I add a new type because this version
> > has new features (e.g. DMA) which will be added somewhen later.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
...
> > @@ -625,6 +627,7 @@ static const struct of_device_id rcar_i2c_dt_ids[] = {
> > { .compatible = "renesas,i2c-r8a7792", .data = (void *)I2C_RCAR_GEN2 },
> > { .compatible = "renesas,i2c-r8a7793", .data = (void *)I2C_RCAR_GEN2 },
> > { .compatible = "renesas,i2c-r8a7794", .data = (void *)I2C_RCAR_GEN2 },
> > + { .compatible = "renesas,i2c-r8a7795", .data = (void *)I2C_RCAR_GEN3 },
>
> If H3 is compatible with Gen2, can't you just use I2C_RCAR_GEN2 here ? You can
> always add I2C_RCAR_GEN3 later if you find differences.
Is the patch description not clear enough?
Attachment:
signature.asc
Description: Digital signature
