Hi Michal, On Mon, Aug 3, 2015 at 7:32 AM, Michal Simek <michal.simek@xxxxxxxxxx> wrote: > NACK for this. Previous driver version did automatic detection directly > on the IP. You are changing it to be OF driven with is error prone and > highly depends on user. I beg do differ. Using the appropriate dt binary attributes is not error prone. On the contrary, it gives the user much tighter control. I find the solution I replaced more of a hack than anything. It writes to reserved bits, which -- while unlikely -- might become used in future versions of this IP. If there was some fixed identification register, sure, this might be okay. If you want to retain this functionality, we might put it in using another CONFIG_I2C_XILINX_XXX option. How's that? Regards, Robert -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
